Merged
Conversation
…are builder for developers to use, added CORS middleware, updated logging middleware to utilize the builder, added a middleware type, updated router to run the middlewares before handling OPTIONS and such, updated controller type to use new middleware type
…ted README.MD with fixed grammar
viktorkuts
approved these changes
Jul 15, 2025
Collaborator
viktorkuts
left a comment
viktorkuts
left a comment
There was a problem hiding this comment.
Looks good, great overhaul of the middleware logic and CORS looks to be properly implemented.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this branch, I've added CORS to work, I also completely over-hauled the way that middleware is interpreted by the router. Router has also changed and will now have pre-middlewares run prior to certain checks and actions.
Added HttpMethod enum to allow for easier visibility of Http Methods without importing GO's build in Http package.
Added a new middleware builder that allows users to create their own middlewares and for our system to actually recognize and utilize their middlewares