Skip to content

Remove the import of imp.find_module.#30

Open
abadger wants to merge 1 commit intoironfroggy:masterfrom
abadger:remove-imp
Open

Remove the import of imp.find_module.#30
abadger wants to merge 1 commit intoironfroggy:masterfrom
abadger:remove-imp

Conversation

@abadger
Copy link
Copy Markdown

@abadger abadger commented Jun 13, 2022

Usage of find_module has been replaced by importlib.

The imp module is going to be removed in python 3.12

Usage of find_module has been replaced by importlib.

The imp module is going to be removed in python 3.12
@ferdnyc
Copy link
Copy Markdown

ferdnyc commented Jan 25, 2024

@ironfroggy Any chance you could merge this and do a new straight.plugin release, please? imp is indeed gone in Python 3.12, and while straight.plugin==1.5.0 can be made to work by installing zombie-imp, switching to importlib is a no-brainer. (Particularly since imp.find_module isn't even used.)

pypingou pushed a commit to Pagure/pagure that referenced this pull request Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants