Reintroduce type parameter lost in the rewrite for Email::Sender.#12
Open
racke wants to merge 1 commit intoironcamel:email-senderfrom
Open
Reintroduce type parameter lost in the rewrite for Email::Sender.#12racke wants to merge 1 commit intoironcamel:email-senderfrom
racke wants to merge 1 commit intoironcamel:email-senderfrom
Conversation
Contributor
Author
|
Note: MIME::Entity doesn't seem to support Format 'flowed'. Regards |
Owner
|
I used part of your patch to add support for html and plain text emails. I have not yet added support for type 'multi'. Take a look: 1e66a34 |
Owner
|
I added a line: I noticed that you said MIME::Entity does not support Format 'flowed'. I am assuming that MIME::Entity would just pass that header on to the client and it is the job of the client to support format flowed or not. I'm not sure how exactly to test format 'flowed', but leaving that line at least does not seem to break anything. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed fix for the following GitHub issue:
#10
Regards
Racke