update: adds locale testing for DATABASE functions #718
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # base/src/test/test_database.rs
elsaminsut
force-pushed
the
formattingtests
branch
from
4121efa to
14b7daf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds testing for different locale formats in the DATABASE functions. For example, in workbooks with en-US locale, dates in MM/DD/YY format should be correctly handled.
For comparison, a test with dates in the ISO format (YYYY-MM-DD) is included as well.
It also includes an example where two locale formats are mixed: a workbook with en-US locale with DD.MM.YYYY dates (used in de-DE locale) should produce the same results as using an empty criteria range.