feat: Add extensive tests for cell behavior and styles #640
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nhatcher
reviewed
Dec 17, 2025
Member
nhatcher
left a comment
nhatcher
left a comment
There was a problem hiding this comment.
The failing tests might not be related to your changes. I will check soon.
Many thanks!
| model._set("A5", "1+2"); | ||
| model._set("A6", "TRUE"); | ||
| model._set("A7", "#VALUE!"); | ||
| model._set("A8", "=Z100"); // an empty cell, considered to be a CellType::Number |
Member
There was a problem hiding this comment.
Why are you removing this test?
Member
|
Hi @rezat-c , please rebase main. I fixed the issue with the failing tests |
Contributor
Author
|
done |
nhatcher
requested changes
Dec 22, 2025
Member
nhatcher
left a comment
nhatcher
left a comment
There was a problem hiding this comment.
Maybe a valid test is being removed?
| model._set("A5", "1+2"); | ||
| model._set("A6", "TRUE"); | ||
| model._set("A7", "#VALUE!"); | ||
| model._set("A8", "=Z100"); // an empty cell, considered to be a CellType::Number |
added 14 commits
December 22, 2025 22:35
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR expands the test suite for the base crate, focusing on cell properties and styling.