fix: INTERVAL type validation #134
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Permit intervals less than 1 month, 1 day, and 1 millisecond.
jim-lake
pushed a commit
to jim-lake/parquetjs
that referenced
this pull request
Oct 15, 2025
Update the project to use ZenFs instead of BrowserFs, as BrowserFs is now deprecated. ironSource#127
jim-lake
pushed a commit
to jim-lake/parquetjs
that referenced
this pull request
Oct 15, 2025
- Previous version of zenfs-core had an engine requirement of >=22 which was higher than the engine requirement for this library (18.18.2) which caused issues with installing the library using yarn. (Yarn seemed to error on engine mismatch but trying it with npm just seemed to log a warning) # Problem In release 1.8.0 the browserfs dependency was replaced with zenfs (ironSource#134). This ^0.14.0 version has a engine requirement of 22, which has caused issues when I've tried to install this package in a node 18 project. The engine requirement for this library is 18.18.2. Solution ======== In the 0.15.1 release of `@zenfs/core` they've added a polyfill and reduced the engine requirement to node 16. https://github.com/zen-fs/core/releases/tag/v0.15.1 I've bumped the version all the way to ^0.16.0 in case there were other fixes along the way. The rest of the changelogs can be seen: https://github.com/zen-fs/core/releases You can see in the `package-lock.json` that the engine requirement has changed from 22 to 16. ## Change summary: - Bump version of @zenfs/core to ^0.16.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Permit intervals less than 1 month, 1 day, and 1 millisecond.