Skip to content

Correctly handle images with dots in their names #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
vasilev wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Correctly handle images with dots in their names #41

vasilev wants to merge 1 commit into from

Conversation

@vasilev
Copy link
Contributor

@vasilev vasilev commented Jan 4, 2018

Correctly handle images with dots in their names, e.g. "brandonmoser/meteor-node-0.10.41".

BupycHuk
BupycHuk approved these changes Jan 4, 2018
View reviewed changes
Copy link
Contributor

@BupycHuk BupycHuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alex-litvak
Copy link

alex-litvak commented Jan 4, 2018

Fantastic! Thank you @vasilev

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vlopatkin vlopatkin Awaiting requested review from vlopatkin

@alex-litvak alex-litvak Awaiting requested review from alex-litvak

1 more reviewer

@BupycHuk BupycHuk BupycHuk approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@vasilev @alex-litvak @BupycHuk