-
Notifications
You must be signed in to change notification settings - Fork 74
[#771] Use named loggers instead of directly calling logging #770
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
oh, very nice. thank you. we'll get an issue created and linked. |
d-w-moore
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good! I've made an issue for this, #771, so @stevenvdb if you could link to that issue into the commit message, (we usually just prepend a string like [_771] for instance, referencing the issue) I think we can approve it fairly quickly.
f2f18dd to
36e4a24
Compare
korydraughn
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
@d-w-moore Awaiting your approval.
|
@stevenvdb Please update the commit message to use a Thanks for your contribution! |
|
@stevenvdb - I can see a commit with the updated commit message here: stevenvdb@f2f18dd But that commit does not appear to be on any branch, or at least it's not on the branch for this PR. Can you please push that commit to the |
36e4a24 to
1682381
Compare
I was out of office, the commit message has now been updated. |
|
Excellent! Thanks. |
|
Merging. |
In most places, python-irodsclient uses named loggers (e.g.,
logger = logging.getLogger(__name__); logger.debug(...)). This is nice because it allows to separate logging done by the Python code using the irodsclient from the logging of irodsclient itself. There were however still a few cases where the root logger was used and this PR corrects that.