Fix dynamic pipeline remainder loop start#1067
Merged
Conversation
When max_iv < rounding_stride the pipeline conditional returns init values and the remainder loop must start from 0 instead of pipelined_iterations. Use sympy.Piecewise to pick the correct start. Signed-off-by: xintin <gaurav.verma@amd.com> Made-with: Cursor
41fa709 to
2fe13c4
Compare
2fe13c4 to
59eb6de
Compare
Contributor
Author
|
waiting for ci to pass. saw a couple flaky test failures in the earlier PR. |
harsh-nod
reviewed
Mar 6, 2026
harsh-nod
reviewed
Mar 6, 2026
harsh-nod
approved these changes
Mar 6, 2026
Signed-off-by: xintin <gaurav.verma@amd.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When max_iv < rounding_stride the pipeline conditional returns init values and the remainder loop must start from 0 instead of pipelined_iterations. Use sympy.Piecewise to pick the correct start.
The remainder loop always starts at pipelined_iterations, regardless of whether the guard was true or false. When the guard is false (the pipeline didn't run), the start should be 0, not pipelined_iterations.