[water] Add FX importer handler for wave.shuffle#1062
Merged
martin-luecke merged 4 commits intomainfrom Mar 6, 2026
Merged
Conversation
martin-luecke
force-pushed
the
users/martin/shuffle_conversion
branch
from
34897f2 to
53d9de5
Compare
ftynse
approved these changes
Mar 6, 2026
Contributor
ftynse
left a comment
ftynse
left a comment
There was a problem hiding this comment.
Looks good, one minor concern about complexity of testing
martin-luecke
force-pushed
the
users/martin/attention_op_handlers
branch
from
6444ba1 to
7a93129
Compare
Signed-off-by: Martin Lücke <martin.luecke@amd.com>
Signed-off-by: Martin Lücke <martin.luecke@amd.com>
Signed-off-by: Martin Lücke <martin.luecke@amd.com>
martin-luecke
force-pushed
the
users/martin/shuffle_conversion
branch
from
0884da5 to
b614492
Compare
Signed-off-by: Martin Lücke <martin.luecke@amd.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The water emitter (FX → MLIR) already supports wave.shuffle. This adds the reverse direction (MLIR → FX) via
_handle_shuffle_op, completing full roundtrip support for shuffle ops across all four modes.This is the last missing op for the attention roundtrip — all attention-relevant ops are now handled by the importer. The remaining attention failures are structural comparison issues unrelated to op coverage.