[compiler] Fix Rational codegen and pipeline unroll bug for dynamic s…#1057
Merged
harsh-nod merged 1 commit intoiree-org:mainfrom Mar 6, 2026
Merged
[compiler] Fix Rational codegen and pipeline unroll bug for dynamic s…#1057harsh-nod merged 1 commit intoiree-org:mainfrom
harsh-nod merged 1 commit intoiree-org:mainfrom
Conversation
harsh-nod
force-pushed
the
32x64x256
branch
2 times, most recently
from
32ebfdf to
625613a
Compare
xintin
approved these changes
Mar 6, 2026
… dynamic shapes Handle _Rational values in Piecewise/select expressions by resolving them via floor division before passing to arith.select, which cannot operate on deferred _Rational values. Fix pipeline unroll interaction for dynamic shapes where the kernel loop count was not divisible by the unroll factor, causing the scf.for loop to execute extra iterations that read invalid pipeline state. Thread unroll_factor through PipelinedLoop to build_guarded_pipeline_with_remainder and use lcm(num_stages, unroll_factor) as the rounding stride for pipelined_iterations. Add (32,64,256) block shape to testScaledGemmMXFP4PreshuffleBDynamic. Signed-off-by: Harsh Menon <harsh.menon@amd.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…hapes
Handle _Rational values in gen_sympy_index for Max, Min, Piecewise, and comparison operators (StrictGreaterThan, GreaterThan, Eq, Ne) that previously threw CodegenError with non-standard block sizes.
Fix pipeline unroll interaction for dynamic shapes where the kernel loop count was not divisible by the unroll factor, causing the scf.for loop to execute extra iterations that read invalid pipeline state. Thread unroll_factor through PipelinedLoop to
build_guarded_pipeline_with_remainder so pipelined_iterations is rounded to guarantee divisibility.
Extend testScaledGemmMXFP4PreshuffleB with a new block shape (32,64,256) at shape (1024,2048,16384), wave_shape and dynamic_shapes parameters.