Enable GC Safe mode #9
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue was in `start` that since I had already restricted `T` to the two kinds of handlers (To make multisync work) it didn't allow the gcsafety to pass through Might need to make my own multisync
By not restricting it we can make it extend to gcsafe procs also
… setting exact parameters
Needed to export the proc (maybe this is a good use of typebound ops?)
Bug is fixed on devel so at some point we can remove the strange code and just bump the min version
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small cleanup to internals. Fixe #7
Exposes
newSchedulerBasewhich allows for restricting the proc type to how you want it (This then allows for restricting effects, exceptions, etc).The
startis then broken up into async/sync version (there were a lot ofwhenstatements anyways). This is to get aroundmultisyncneeding me to specify the two different versions which locked the tasks being non gcsafe (Since thats what the types were specified as).Want to clean up the code a bit more first though