HHVM (HipHop VM) current limits output to the first 255 bytes of output....#16
Open
navecommunications wants to merge 1 commit intoircmaxell:masterfrom
Open
HHVM (HipHop VM) current limits output to the first 255 bytes of output....#16navecommunications wants to merge 1 commit intoircmaxell:masterfrom
navecommunications wants to merge 1 commit intoircmaxell:masterfrom
Conversation
…ut. If the prefix exceeds this, the returned string never contains any added entropy, nor can it ever grow passed 255 bytes trapping us in an infinite loop if we request a larger string. Concatenating the prefix and the generated should theoretically be faster through the uniqid function, so we'll only concatenate our own if we're running HHVM, as well as have two seperate loops available so we only have to evalute if we're running HHVM once vs every iteration of a singular loop.
Owner
|
Why not open this as a bug against HHVM, as it's clearly working fine in core? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
... If the prefix exceeds this, the returned string never contains
any added entropy, nor can it ever grow passed 255 bytes trapping us in an infinite loop if we request a larger string. Concatenating
the prefix and the generated should theoretically be faster through the uniqid function, so we'll only concatenate our own if we're
running HHVM, as well as have two seperate loops available so we only have to evalute if we're running HHVM once vs every iteration
of a singular loop.