-
Notifications
You must be signed in to change notification settings - Fork 135
implement status icon blinking #714
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey - I've left some high level feedback:
- The blink timer management logic is duplicated between AppIndicatorMac.mm and AppIndicator.cpp; consider extracting a small shared helper (or at least a common pattern/utility) so the behavior stays in sync and is easier to maintain.
- For managing blinkTimerId, consider using the GLib helper pattern (e.g., g_clear_handle_id-style logic) to ensure the ID is always cleared in a single place and to make repeated start/stop calls safer and less error-prone.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The blink timer management logic is duplicated between AppIndicatorMac.mm and AppIndicator.cpp; consider extracting a small shared helper (or at least a common pattern/utility) so the behavior stays in sync and is easier to maintain.
- For managing blinkTimerId, consider using the GLib helper pattern (e.g., g_clear_handle_id-style logic) to ensure the ID is always cleared in a single place and to make repeated start/stop calls safer and less error-prone.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #714 +/- ##
==========================================
- Coverage 52.11% 51.81% -0.30%
==========================================
Files 64 64
Lines 8641 8694 +53
==========================================
+ Hits 4503 4505 +2
- Misses 4138 4189 +51 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
TODO
Summary by Sourcery
Add blinking behavior to the status icon when in blinking mode and unread messages are present, and stop blinking when the window becomes active.
New Features:
Enhancements: