Skip to content

Conversation

@lidaobing
Copy link
Member

@lidaobing lidaobing commented Jan 30, 2026

TODO

  • send message should not trigger blinking
  • open chat window should clear the blinking state
  • config window should be optimized

Summary by Sourcery

Add blinking behavior to the status icon when in blinking mode and unread messages are present, and stop blinking when the window becomes active.

New Features:

  • Introduce a blinking status icon mode that alternates between normal and reverse icons for unread messages on macOS and Linux.
  • Automatically stop the blinking status icon when the application window becomes active.

Enhancements:

  • Ensure timers and icon resources for status indicators are properly cleaned up when indicators are destroyed or modes change.

@lidaobing lidaobing linked an issue Jan 30, 2026 that may be closed by this pull request
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • The blink timer management logic is duplicated between AppIndicatorMac.mm and AppIndicator.cpp; consider extracting a small shared helper (or at least a common pattern/utility) so the behavior stays in sync and is easier to maintain.
  • For managing blinkTimerId, consider using the GLib helper pattern (e.g., g_clear_handle_id-style logic) to ensure the ID is always cleared in a single place and to make repeated start/stop calls safer and less error-prone.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- The blink timer management logic is duplicated between AppIndicatorMac.mm and AppIndicator.cpp; consider extracting a small shared helper (or at least a common pattern/utility) so the behavior stays in sync and is easier to maintain.
- For managing blinkTimerId, consider using the GLib helper pattern (e.g., g_clear_handle_id-style logic) to ensure the ID is always cleared in a single place and to make repeated start/stop calls safer and less error-prone.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@github-actions
Copy link

github-actions bot commented Jan 30, 2026

Test Results

69 tests  ±0   69 ✅ ±0   2s ⏱️ -1s
32 suites ±0    0 💤 ±0 
 1 files   ±0    0 ❌ ±0 

Results for commit 10499b3. ± Comparison against base commit 60cd410.

♻️ This comment has been updated with latest results.

@codecov
Copy link

codecov bot commented Jan 30, 2026

Codecov Report

❌ Patch coverage is 6.89655% with 54 lines in your changes missing coverage. Please review.
✅ Project coverage is 51.81%. Comparing base (60cd410) to head (10499b3).

Files with missing lines Patch % Lines
src/iptux/AppIndicator.cpp 0.00% 48 Missing ⚠️
src/iptux/DialogBase.cpp 16.66% 5 Missing ⚠️
src/iptux/UiModels.cpp 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #714      +/-   ##
==========================================
- Coverage   52.11%   51.81%   -0.30%     
==========================================
  Files          64       64              
  Lines        8641     8694      +53     
==========================================
+ Hits         4503     4505       +2     
- Misses       4138     4189      +51     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@iptux-src iptux-src deleted a comment from sourcery-ai bot Jan 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

消息闪动

2 participants