Skip to content

Conversation

@2color
Copy link
Contributor

@2color 2color commented Aug 12, 2025

@2color 2color requested a review from lidel August 12, 2025 12:43
"sync-version": "node scripts/sync-version.mjs",
"build": "npm run sync-version && tsc && cp src/manifest.json dist/ && cp src/popup.html dist/ && cp -r src/icons dist/",
"package": "npm run build && web-ext build --source-dir=dist --artifacts-dir=. --filename=ipfs-quicklaunch-{version}.zip --overwrite-dest",
"package": "npm run build && web-ext build --source-dir=dist --artifacts-dir=. --filename=ipfs-quicklaunch.zip --overwrite-dest",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lidel Was there any reason to include the version in the zip file?

This makes it a bit harder to automate the publishing, so I changed to a static name to keep things simple.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no hard reason, it is just a convention of mine, makes it easy to work with artifacts if you download multiple versions for regression testing, but fine to remove version from name if it makes things easier.

@2color 2color merged commit c64f29b into main Aug 12, 2025
@github-actions
Copy link

🎉 This PR is included in version 1.2.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants