Skip to content

feat: add timeout and retry logic to cluster uploads #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
2color merged 7 commits into from
Feb 21, 2025
Merged

feat: add timeout and retry logic to cluster uploads #12

2color merged 7 commits into from
Feb 21, 2025

Conversation

@2color
Copy link
Contributor

@2color 2color commented Feb 19, 2025

  • fix: remove duplicate link
  • update changelog
  • feat: add timeout and retries to ipfs cluster

@2color 2color requested a review from lidel February 19, 2025 16:23
lidel
lidel approved these changes Feb 20, 2025
View reviewed changes
Copy link
Contributor

@lidel lidel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, small nits inline – fine to ship as-is and address them later.

@github-actions
Copy link

github-actions bot commented Feb 21, 2025

v1.0.0

Added

  • Add timeout and retry logic to IPFS Cluster uploads.
    • Uploads to IPFS Cluster have a default timeout of 5 minutes.
    • If the upload fails, the action will retry by default 3 times with a 5 second delay between attempts.
    • The number of retry attempts and timeout can be customized using the cluster-retry-attempts and cluster-timeout-minutes inputs.

Fixed

  • Remove duplicate preview link from PR comment.

@2color 2color merged commit 8dc8306 into main Feb 21, 2025
1 check passed
@2color 2color deleted the add-timeout-retry branch February 21, 2025 11:17
@2color 2color mentioned this pull request Mar 3, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lidel lidel lidel approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@2color @lidel