Bugfix: Add missing migration to sqlite #80
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Níckolas Goline <nickolas.goline+github@gmail.com>
Combined Test Results 17 files 17 suites 45s ⏱️ Results for commit a1c9b24. ♻️ This comment has been updated with latest results. |
Signed-off-by: Níckolas Goline <nickolas.goline+github@gmail.com>
|
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request claims to add a missing SQLite migration (fixing issue #78), but actually adds a Postgres migration while the SQLite migration is still missing. The PR also includes package version updates to test projects and various code quality improvements including nullable reference type fixes, code cleanup, and refactoring.
Critical Issues:
- The Postgres migration has a timestamp mismatch between filename (20251204) and Migration attribute (20250612)
- Multiple test projects reference nonexistent package versions (Microsoft.NET.Test.Sdk 18.0.1 and xunit.runner.visualstudio 3.1.5)
- The PR title promises a SQLite migration but doesn't deliver it
Key Changes:
- Added Postgres migration
AddBlockchaisStateAndWatchedTransaction(with incorrect timestamp) - Updated test package versions to nonexistent future versions
- Improved code quality: removed redundant null checks, cleaned up unused variables, fixed lambda expressions, improved type casting patterns
Reviewed changes
Copilot reviewed 39 out of 41 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/NLightning.Infrastructure.Persistence.Postgres/Migrations/20251204210605_AddBlockchaisStateAndWatchedTransaction.cs | New Postgres migration for blockchain state and watched transactions (migration timestamp mismatch) |
| src/NLightning.Infrastructure.Persistence.Postgres/Migrations/20251204210605_AddBlockchaisStateAndWatchedTransaction.Designer.cs | Migration designer file with incorrect timestamp in Migration attribute |
| test/NLightning.Node.Tests/NLightning.Node.Tests.csproj | Updated test packages to nonexistent versions (18.0.1, 3.1.5) |
| test/NLightning.Integration.Tests/NLightning.Integration.Tests.csproj | Updated test packages to nonexistent versions |
| test/NLightning.Infrastructure.Tests/NLightning.Infrastructure.Tests.csproj | Updated test packages to nonexistent versions |
| test/NLightning.Infrastructure.Serialization.Tests/NLightning.Infrastructure.Serialization.Tests.csproj | Updated test packages to nonexistent versions |
| test/NLightning.Infrastructure.Bitcoin.Tests/NLightning.Infrastructure.Bitcoin.Tests.csproj | Updated test packages to nonexistent versions |
| test/NLightning.Domain.Tests/NLightning.Domain.Tests.csproj | Updated test packages to nonexistent versions |
| test/NLightning.Bolt11.Tests/NLightning.Bolt11.Tests.csproj | Updated test packages to nonexistent versions |
| test/NLightning.Application.Tests/NLightning.Application.Tests.csproj | Updated test packages to nonexistent versions and NBitcoin to 9.0.3 |
| test/NLightning.Tests.Utils/Mocks/FakeServiceProvider.cs | Changed GetService return type from nullable to non-nullable (creates misleading code) |
| test/NLightning.Infrastructure.Tests/Bitcoin/Wallet/BlockchainMonitorServiceTests.cs | Cleaned up unused fields, improved test code organization and type casting |
| src/NLightning.Infrastructure/Transport/Handshake/States/HandshakeState.cs | Simplified ArgumentNullException.ThrowIfNull usage |
| src/NLightning.Infrastructure/Transport/Encryption/Transport.cs | Simplified ArgumentNullException.ThrowIfNull usage |
| src/NLightning.Infrastructure.Bitcoin/Signers/LocalLightningSigner.cs | Removed unnecessary int cast |
| src/NLightning.Domain/Utils/Extensions/ByteArrayExtensions.cs | Fixed lambda expression by removing redundant assignment |
| src/NLightning.Domain/Protocol/ValueObjects/BigSize.cs | Updated XML doc parameter name to match record parameter |
| src/NLightning.Domain/Protocol/Interfaces/IDustService.cs | Fixed namespace and removed trailing blank line |
| Multiple test files | Added null-forgiving operators and #pragma warnings to suppress nullable reference warnings |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #78