Update cid version to v0.11.1 and multihash to v0.19.3#201
Closed
afbase wants to merge 7 commits intoipld:masterfrom
Closed
Update cid version to v0.11.1 and multihash to v0.19.3#201afbase wants to merge 7 commits intoipld:masterfrom
afbase wants to merge 7 commits intoipld:masterfrom
Conversation
Author
|
I think we're very close. I'm not sure how to best go about the lint issue and if maintainers can get this over the hump, that would be greatly appreciated. |
Author
|
cc: @vmx |
Author
|
the main issue is this dependency_on_unit_never_type_fallback. quote! {
#[allow(dependency_on_unit_never_type_fallback)]
#encode
#[allow(dependency_on_unit_never_type_fallback)]
#decodeI'm not sure how you feel about it but the idea above I think would pass all tests if we modify |
Author
|
see #202
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
relates to #197