Conversation
Member
willscott
commented
Mar 4, 2022
- there's probably a better algorithm for the skip/don't skip subset of interests that are to be recursively traversed versus what's set up here.
- there might be a way to combine the list and map recursion methods
- should think about a reasonable set of test cases / fixtures
warpfork
approved these changes
Mar 6, 2022
Collaborator
warpfork
left a comment
There was a problem hiding this comment.
+1 from me. (Not a detailed review; but it looks about right.)
I'm... probably not going to harp on test fixtures for this too much, for once (surprising though that might be). I think this function may be a golang-specific cul-de-sac a bit, and therefore I care a lot less.
When using `traversal.WalkTransforming`, progress is created without a cfg / linksystem. If links are present, that fails when it does not need to.
willscott
added a commit
to ipld/go-car
that referenced
this pull request
Mar 6, 2022
Note: depends on ipld/go-ipld-prime#376
Member
Author
|
I considered if this needs to add the partial skip logic added in #358. I believe in the same way that it is not used for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.