Closed
Conversation
rvagg
commented
Aug 23, 2022
|
|
||
| for r, store := range identityRoots { | ||
| if store { | ||
| records = append(records, index.Record{Cid: r, Offset: uint64(1)}) |
Member
Author
There was a problem hiding this comment.
I'd rather this be 0 but it can't be because of https://github.com/filecoin-project/index-provider/blob/b918da7508b05263988561ec3f28ca31e0fcacb9/multihash_iterator.go#L48-L52
But also, is it really something we should report to the indexer, perhaps it should get filtered out before it gets there. 🤷
rvagg
added a commit
to filecoin-project/boost
that referenced
this pull request
Aug 23, 2022
Member
Author
|
not proceeding with this approach |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Exploring options for filecoin-project/boost#715, this is just some code to test out an option, no need to take this seriously yet.