Add support for scripts during initialization#8337
Closed
vk496 wants to merge 1 commit intoipfs:masterfrom
Closed
Conversation
Contributor
lidel
reviewed
Sep 3, 2021
| init_scripts /docker-prehook.d | ||
|
|
||
| # Post-hook init scripts | ||
| { sleep 10; init_scripts /docker-posthook.d ; } & |
Member
There was a problem hiding this comment.
Separate stage after sleeping for 10 seconds feels brittle. Could not be enough if my node runs on slow CI and takes longer time to init/start etc.
I feel we don't need a separate directory with posthooks executed after a hardcoded delay. If anything, we would be waiting for node to start (eg. by probing /api/v0/id on the API port etc).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This functionality was suggested by #387 (comment)
I saw @Caian PR #6577 after, so I publish my suggestion anyway
This patch will enable more complex init patterns during the IPFS first initialization. The scripts under /docker-prehook.d directory will be executed just after all env initialization and BEFORE running ipfs daemon. If there were no errors, it will execute the ipfs daemon. AFTER running ipfs daemon (10 seconds) it will execute all scripts under /docker-posthook.d and kill the main ipfs process if any script failed.
Btw, I'm not sure if the documentation of this functionality should go to the README.md or to https://github.com/ipfs/ipfs-docs/