cmds/pin: add force option for pin rm

[overbool]

Fixes: #5716

License: MIT
Signed-off-by: Overbool overbool.xu@gmail.com

[kevina]

@overbool could you add a sharness test for this?

[kevina]

To make sure things are working right I would do

ipfs pin rm --force <invalid-hash> <valid-hash> <invalid-hash>

[schomatis]

We should report nonexisting hashes.

As suggested by @kevina I'm fine with making this the default behavior without the flag to mimic block rm .

[overbool]

@kevina @schomatis Currently, we had implemented the PinAPI.Rm in coreapi/pin.go, but we haven't used it yet. Should we use PinAPI.Rm?

Another question is should we deprecate corerepo/pinning.go? Because I think we can implement all function about pin in coreapi/pin.go.

[schomatis]

I'm not sure, @magik6k might know more about that, but those issues seem more suited to be handled in another PR to avoid mixing different solutions.

[overbool]

@magik6k Should we deprecate corerepo/pinning.go and implement all pin function in coreapi/pin.go.(like coreapi.BlockAPI)?

[magik6k]

Sorry for the delay. Yep, we can remove corerepo/pinning.go and just use CoreAPI.

[magik6k]

I'm guessing we want #5843 in first