Merged
Conversation
Stebalien
approved these changes
Aug 21, 2018
Member
Stebalien
left a comment
Stebalien
left a comment
There was a problem hiding this comment.
I'd call this InlineBuilder or InliningBuilder to be a bit more descriptive but that's up to you.
This really is elegant.
inliner.go
Outdated
| // size of the content is no more than limit | ||
| type Inliner struct { | ||
| cid.Builder | ||
| Limit int |
Member
There was a problem hiding this comment.
Should probably be documented (inclusive? exclusive?).
Contributor
Author
There was a problem hiding this comment.
Do you mean "Limit"? I said above "size of the content is no more than limit" which should imply inclusive.
Member
There was a problem hiding this comment.
Ah. I didn't see that. Yes, that should be sufficient.
Member
|
I'm still not in love with the name but feel free to merge when ready. LGTM. |
Contributor
Author
|
@Stebalien Changed the name to InlineBuilder. Merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Will be used by ipfs/kubo#5281.
CC @Stebalien