WIP: Use string as the internal representation and allow an associated multibase.#65
Closed
WIP: Use string as the internal representation and allow an associated multibase.#65
Conversation
Authors: Steven Allen <steven@stebalien.com> dignifiedquire@gmail.com Kevin Atkinson <k@kevina.org>
Member
|
As I've stated before, mixing representation with data is almost never something one should do.
|
Contributor
Author
|
@Stebalien both (1) and (2) are fine. If the information is lost that's okay the idea was to preserve it when possible. For (3) we will have to agree to disagree. As I see it it is threading through optional metadata that just "goes along for the ride". However, I can see how this add complexity and don't plan to push it. |
Contributor
Author
|
Closing, as we are going with a pure string representation. Please don't delete the branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an alternative to #64 to explore the design space.
The main advantage of this is that it does not break any existing code.
This might also perform a little better, but I image it will be negligible.