Create a new Encode method that is like StringOfBase but never errors #60
Merged
Create a new Encode method that is like StringOfBase but never errors #60
Conversation
ghost
assigned
kevina
force-pushed
the
kevina/cid-fmtb
branch
2 times, most recently
from
5768359 to
990a524
Compare
kevina
changed the title
Merged
kevina
force-pushed
the
kevina/cid-fmtb
branch
3 times, most recently
from
9e889ff to
70097b5
Compare
Contributor
Author
|
CC: @Stebalien for review. |
kevina
changed the title
Stebalien
reviewed
Aug 11, 2018
cid.go
Outdated
| } | ||
|
|
||
| // Encode return the string representation of a Cid in a given base | ||
| // when applicable |
Member
There was a problem hiding this comment.
I'd definitely expand on the edge cases here. Other than that, I have no real objections if we end up needing this.
kevina
changed the title
kevina
force-pushed
the
kevina/cid-fmtb
branch
from
70097b5 to
b3d85b3
Compare
Contributor
Author
|
@Stebalien this will end up being useful. If we are going to push #71 though in the next couple of days I would like to get this in also. |
Stebalien
approved these changes
Aug 30, 2018
Member
|
We should probably also deprecate |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The idea is that we can just replace calls to
String()withEncode(base). For this to work we need a method that will return meaningful results for all CIDs and never errors.Used by ipfs/kubo#5289.