Closed
Conversation
Unlike Prefix, we can extend continue to extend this helper as the options grow.
ghost
assigned
Stebalien
commented
Jun 28, 2018
| inlineMax int | ||
| } | ||
|
|
||
| // TODO: detect bad formats? Probably not worth it. We catch them on Sum anyways. |
| } | ||
| } | ||
|
|
||
| // TODO: Split length and hash? |
| mh "github.com/multiformats/go-multihash" | ||
| ) | ||
|
|
||
| // TODO: Move these to the correct go-ipld-* crates? |
| } | ||
|
|
||
| // TODO: Do we actually want this or should users always extend Format | ||
| // That is, DagCBORFormat.With(OptHash(...)) |
Contributor
|
@Stebalien what I had in mind was something a little simpler but more extensible I will create a new p.r. with what I had in mind. |
Member
Author
|
Closing in favor of #53. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unlike Prefix, we can extend continue to extend this helper as the options grow.