test: add missing DNSLink -> IPNS resolution#272
Merged
Conversation
existing DNSLink tests only cover dnslink=/ipfs/<cid>, but the dnslink=/ipns/<key> path is untested. reuse the Ed25519 IPNS record fixture from subdomain_gateway/ to verify the gateway resolves DNSLink -> IPNS -> content correctly.
lidel
changed the title
Contributor
|
Results against Kubo master: Summary
|
Contributor
|
Results against Kubo latest: Summary
|
lidel
added a commit
to ipfs/kubo
that referenced
this pull request
Feb 23, 2026
point gateway-conformance actions at ipfs/gateway-conformance@14c75521 which adds a conformance test for DNSLink TXT records pointing to /ipns/<key> instead of /ipfs/<cid>. ref: ipfs/gateway-conformance#272
lidel
added a commit
to ipfs/kubo
that referenced
this pull request
Feb 23, 2026
point gateway-conformance actions at ipfs/gateway-conformance@14c75521 which adds a conformance test for DNSLink TXT records pointing to /ipns/<key> instead of /ipfs/<cid>. ref: ipfs/gateway-conformance#272
test both original and inlined DNSLink domain forms when the dnslink TXT record points at /ipns/<key> instead of /ipfs/<cid>.
lidel
added a commit
to ipfs/kubo
that referenced
this pull request
Feb 23, 2026
point gateway-conformance actions at ipfs/gateway-conformance@14c75521 which adds a conformance test for DNSLink TXT records pointing to /ipns/<key> instead of /ipfs/<cid>. ref: ipfs/gateway-conformance#272
test both base58btc peer ID and CIDv1-libp2p-key (base36) forms of IPNS names in DNSLink TXT records across gateway and subdomain tests.
lidel
added a commit
to ipfs/kubo
that referenced
this pull request
Feb 24, 2026
point gateway-conformance actions at ipfs/gateway-conformance@14c75521 which adds a conformance test for DNSLink TXT records pointing to /ipns/<key> instead of /ipfs/<cid>. ref: ipfs/gateway-conformance#272
Fmt treats triple braces {{{...}}} as escaped literals, not template
vars, causing "too many arguments" panic.
Contributor
v0.11.0Added
|
lidel
added a commit
to ipfs/kubo
that referenced
this pull request
Feb 24, 2026
point gateway-conformance actions at ipfs/gateway-conformance@14c75521 which adds a conformance test for DNSLink TXT records pointing to /ipns/<key> instead of /ipfs/<cid>. ref: ipfs/gateway-conformance#272
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
existing DNSLink tests only cover dnslink=/ipfs/, but the dnslink=/ipns/ path is untested. reuse the Ed25519 IPNS record fixture from subdomain_gateway/ to verify the gateway resolves DNSLink -> IPNS -> content correctly.
thank you @aschmahmann for flagging this gap