fix: convert CIDv0 to CIDv1 before base32 encoding#265
Merged
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
lidel
changed the title
lidel
force-pushed
the
fix/base32-cidv0-to-cidv1
branch
from
5ebac0e to
1151145
Compare
Contributor
renamed Base32Cid() to DNSSafeCidV1() to clarify intent. uses base36 for libp2p-key codec (IPNS keys), base32 for everything else. CIDv0 bytes are bare multihashes without version/codec prefix, base32-encoding them directly produces an invalid CID string that spec-compliant parsers (like js-multiformats) reject. Fixes #264
lidel
force-pushed
the
fix/base32-cidv0-to-cidv1
branch
from
1151145 to
ad98c7a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CIDv0 bytes are bare multihashes without version/codec prefix. Base32-encoding them directly produces an invalid CID string that spec-compliant parsers (like js-multiformats) reject.