Skip to content

fix: dag-index html cache-control matches dir-index html#241

Merged
lidel merged 2 commits intomainfrom
fix/dag-index-html-cache-control-expectation
Jun 17, 2025
Merged

fix: dag-index html cache-control matches dir-index html#241
lidel merged 2 commits intomainfrom
fix/dag-index-html-cache-control-expectation

Conversation

@SgtPooki
Copy link
Member

Fixes #240

@github-actions
Copy link
Contributor

Results against Kubo latest:
(check the action's summary for the full results)

Summary

Tests Failures Errors Skipped
1328 3 0 0

@github-actions
Copy link
Contributor

Results against Kubo master:
(check the action's summary for the full results)

Summary

Tests Failures Errors Skipped
1328 0 0 0

@SgtPooki SgtPooki requested a review from lidel June 17, 2025 01:17
@SgtPooki SgtPooki self-assigned this Jun 17, 2025
@github-actions
Copy link
Contributor

v0.8.1

Changed

  • DAG-CBOR HTML preview pages previously had to be returned without Cache-Control headers. Now they can use Cache-Control headers similar to those used in generated UnixFS directory listings. #241

Copy link
Member

@lidel lidel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch! lgtm

Added changelog to release as v0.8.1

@lidel lidel merged commit 5962ca0 into main Jun 17, 2025
12 checks passed
@gammazero gammazero deleted the fix/dag-index-html-cache-control-expectation branch January 22, 2026 00:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

clarification needed for dag-cbor DagIndex cache-control header

2 participants