fix: main page in case it was created from exception#122
Open
fix: main page in case it was created from exception#122
Conversation
1 task
Contributor
Author
|
@lidel Should we merge this fix to make sure the wikis we want to create in the future have correct main pages set up? |
|
The latest zimdump has a fix regarding main page teporting... maybe it has an impact here. |
Contributor
Author
Either way, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the issues that affected Belarusian wiki for example - #120
In case of Belarusian wiki, the main page lands in exceptions. This means that in the resulting website it's available under
wiki/main_page/index.htmlinstead ofwiki/main_page.When it's copied to
wiki/index.html, one depth level in relative links have to be removed.Previously, we were looking at the input main page path to determine if relative links need to be fixed up. With this change, we will be looking at the actual path (e.g. after exceptions processing).
This fix was tested as part of #123.