Skip to content

Bitswap: move providing -> Exchange-layer, providerQueryManager -> routing #641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gammazero merged 1 commit into from
Nov 25, 2024

Bitswap: refactor content provider elements

6d9cc8b
Select commit
Loading
Failed to load commit list.
Merged

Bitswap: move providing -> Exchange-layer, providerQueryManager -> routing #641

Bitswap: refactor content provider elements
6d9cc8b
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Nov 25, 2024 in 0s

60.35% (-0.08%) compared to c91cc1d, passed because coverage increased by 0.08% when compared to adjusted base (60.27%)

View this Pull Request on Codecov

60.35% (-0.08%) compared to c91cc1d, passed because coverage increased by 0.08% when compared to adjusted base (60.27%)

Details

Codecov Report

Attention: Patch coverage is 81.09453% with 38 lines in your changes missing coverage. Please review.

Project coverage is 60.35%. Comparing base (c91cc1d) to head (6d9cc8b).

Files with missing lines Patch % Lines
...uting/providerquerymanager/providerquerymanager.go 83.54% 12 Missing and 1 partial ⚠️
bitswap/client/client.go 84.44% 6 Missing and 1 partial ⚠️
exchange/providing/providing.go 62.50% 4 Missing and 2 partials ⚠️
bitswap/options.go 0.00% 4 Missing ⚠️
bitswap/client/internal/session/session.go 50.00% 2 Missing and 1 partial ⚠️
bitswap/network/ipfs_impl.go 62.50% 2 Missing and 1 partial ⚠️
bitswap/testnet/virtual.go 83.33% 1 Missing ⚠️
provider/noop.go 0.00% 1 Missing ⚠️

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #641      +/-   ##
==========================================
- Coverage   60.43%   60.35%   -0.08%     
==========================================
  Files         243      244       +1     
  Lines       31059    31034      -25     
==========================================
- Hits        18771    18732      -39     
- Misses      10628    10633       +5     
- Partials     1660     1669       +9
Files with missing lines Coverage Δ
bitswap/bitswap.go 69.13% <100.00%> (+2.07%) ⬆️
...tswap/client/internal/messagequeue/messagequeue.go 84.92% <ø> (ø)
bitswap/server/server.go 56.57% <100.00%> (-5.39%) ⬇️
bitswap/testinstance/testinstance.go 86.44% <100.00%> (+0.23%) ⬆️
bitswap/testnet/peernet.go 38.46% <100.00%> (-4.40%) ⬇️
blockservice/test/mock.go 100.00% <100.00%> (ø)
examples/bitswap-transfer/main.go 41.21% <100.00%> (ø)
provider/provider.go 25.74% <ø> (ø)
provider/reprovider.go 68.63% <100.00%> (+0.59%) ⬆️
routing/mock/centralized_client.go 58.53% <100.00%> (-3.97%) ⬇️
... and 9 more

... and 4 files with indirect coverage changes

View more details on Codecov