This repository was archived by the owner on Mar 10, 2020. It is now read-only.
feat: use latest IPFS, tests pass, avoid using internals#23
Merged
feat: use latest IPFS, tests pass, avoid using internals#23
Conversation
ghost
assigned
Closed
Contributor
Author
|
daviddias
changed the title
achingbrain
approved these changes
Nov 6, 2018
Collaborator
achingbrain
left a comment
achingbrain
left a comment
There was a problem hiding this comment.
LGTM.
In future I'd rather whitespace changes be submitted as a separate PR though please, otherwise the important changes get lost in the noise.
I've opened #24 to track the removal of using IPFS internals - it shouldn't block this fix from going out.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix for #22