This repository was archived by the owner on Mar 10, 2020. It is now read-only.
fix: fix pubsub subscribe with multiple node in firefox#571
Open
hugomrdias wants to merge 1 commit intomasterfrom
Open
fix: fix pubsub subscribe with multiple node in firefox#571hugomrdias wants to merge 1 commit intomasterfrom
hugomrdias wants to merge 1 commit intomasterfrom
Conversation
In firefox one empty msg is send first to start the flow, this PR accounts for that. https://github.com/ipfs/js-ipfs-http-client/blob/master/src/pubsub/subscribe.js#L27-L37
42 tasks
Contributor
|
I was thinking we'd change the empty message to be a special value that the client would recognise and drop silently...this is ugly and I hate it but keeps the hack leaking into other places (like here). |
Contributor
Author
|
close and fix in the clients ? |
Contributor
|
...I'm just not 100% sure if it's possible (I didn't think about it too much) - for instance js-ipfs will still receive the message - do we have tests that send from firefox to a in process JS node? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In firefox one empty msg is send first to start the flow, this PR accounts for that. When merged we can enable the tests in js-ipfs https://github.com/ipfs/js-ipfs/blob/32311655d17f5e5eb3a445be9f68b44e6d60a7ef/test/core/interface.spec.js#L107
ref:
https://github.com/ipfs/js-ipfs-http-client/blob/master/src/pubsub/subscribe.js#L27-L37