This repository was archived by the owner on Mar 10, 2020. It is now read-only.
refactor: Object API write methods return CIDs#399
Merged
Conversation
ghost
assigned
achingbrain
approved these changes
Nov 27, 2018
Collaborator
achingbrain
left a comment
achingbrain
left a comment
There was a problem hiding this comment.
LGTM.
I think the commit linter is objecting (ha) to the capital O in the commit line. It wants it to be refactor: object API instead of refactor: Object API.
Since `ipld-dag-pb` removed `multihash` and `cid` properties, the Object API became less useful, returning the data you provided it when you call methods that write DAG nodes. This meant the user had to calculate the CID manually. This PR updates the Object API so that write methods return CID instances instead of DAG nodes. See discussion here for more context: #388 (review) License: MIT Signed-off-by: Alan Shaw <alan.shaw@protocol.ai>
alanshaw
force-pushed
the
refactor/object-write-return-cid
branch
from
db2aa8b to
bf2c763
Compare
added 2 commits
November 27, 2018 10:50
License: MIT Signed-off-by: Alan Shaw <alan.shaw@protocol.ai>
License: MIT Signed-off-by: Alan Shaw <alan.shaw@protocol.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since
ipld-dag-pbremovedmultihashandcidproperties, the Object API became less useful, returning the data you provided it when you call methods that write DAG nodes. This meant the user had to calculate the CID manually.This PR updates the Object API so that write methods return CID instances instead of DAG nodes.
See discussion here for more context: #388 (review)