This repository was archived by the owner on Mar 10, 2020. It is now read-only.
[WIP] feat: adds tests for name.publish and name.resolve#248
Open
[WIP] feat: adds tests for name.publish and name.resolve#248
Conversation
Contributor
|
Should try to use the new experimental feature for pubsub resolve (but still test the old one as well), but with the flag |
Contributor
|
What's missing here? |
Contributor
Author
|
Just the fact that the tests don't pass and I couldn't figure out why... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
swarm.connect)name.publishon node0name.resolve(/ipns/${node0.peerid})on the otherI could do with some advice possibly from the go-ipfs team(?), as step 4 fails with
Error: Could not resolve name.. Why might that be?Also:
spawnWithIdfunction into a module