-
Notifications
You must be signed in to change notification settings - Fork 1
chore: archive all js-ipfs examples #54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The following access changes will be introduced as a result of applying the plan: Access Changes |
|
Before merge, verify that all the following plans are correct. They will be applied as-is after the merge. Terraform plansipfs-examples |
achingbrain
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Does removing so much config mean those settings won't be changed by the automation or do they revert to some default value?
I am not sure. The config was removed by the automation after I just updated the archived property. @galargh any insights? |
|
When a repository is archived, we remove all the settings from the YAML config here because those cannot be modified on an archived repository. The only toggle that still works on an archived repo is the one that controls its' archived status. If we were to unarchive a repository, all the settings would be brought back to the YAML config automatically as well. To check what will be changed by the automation after the merge, you can always refer to the terraform plan posted as a comment. In this case, it's here - #54 (comment) As you can see there, the only thing the automation touches is the archived status of the repositories. |
Summary
Why do you need this?
What else do we need to know?
DRI: myself
Reviewer's Checklist