Skip to content

Conversation

@2color
Copy link
Contributor

@2color 2color commented Jun 3, 2025

Summary

Why do you need this?

What else do we need to know?

DRI: myself

Reviewer's Checklist

  • It is clear where the request is coming from (if unsure, ask)
  • All the automated checks passed
  • The YAML changes reflect the summary of the request
  • The Terraform plan posted as a comment reflects the summary of the request

@2color 2color requested review from a team as code owners June 3, 2025 06:45
@github-actions
Copy link
Contributor

github-actions bot commented Jun 3, 2025

The following access changes will be introduced as a result of applying the plan:

Access Changes
User 2color:
  - will lose pull permission to js-ipfs-101
  - will lose pull permission to js-ipfs-browser-add-readable-stream
  - will lose pull permission to js-ipfs-browser-angular
  - will lose pull permission to js-ipfs-browser-browserify
  - will lose pull permission to js-ipfs-browser-create-react-app
  - will lose pull permission to js-ipfs-browser-esbuild
  - will lose pull permission to js-ipfs-browser-exchange-files
  - will lose pull permission to js-ipfs-browser-ipns-publish
  - will lose pull permission to js-ipfs-browser-lit
  - will lose pull permission to js-ipfs-browser-mfs
  - will lose pull permission to js-ipfs-browser-nextjs
  - will lose pull permission to js-ipfs-browser-parceljs
  - will lose pull permission to js-ipfs-browser-readablestream
  - will lose pull permission to js-ipfs-browser-script-tag
  - will lose pull permission to js-ipfs-browser-service-worker
  - will lose pull permission to js-ipfs-browser-sharing-node-across-tabs
  - will lose pull permission to js-ipfs-browser-video-streaming
  - will lose pull permission to js-ipfs-browser-vite
  - will lose pull permission to js-ipfs-browser-vue
  - will lose pull permission to js-ipfs-browser-webpack
  - will lose pull permission to js-ipfs-custom-ipld-formats
  - will lose pull permission to js-ipfs-custom-libp2p
  - will lose pull permission to js-ipfs-http-client-browser-pubsub
  - will lose pull permission to js-ipfs-http-client-bundle-webpack
  - will lose pull permission to js-ipfs-http-client-name-api
  - will lose pull permission to js-ipfs-http-client-upload-file
  - will lose pull permission to js-ipfs-ipfs-client-add-files
  - will lose pull permission to js-ipfs-run-in-electron
  - will lose pull permission to js-ipfs-running-multiple-nodes
  - will lose pull permission to js-ipfs-types-use-ipfs-from-ts
  - will lose pull permission to js-ipfs-types-use-ipfs-from-typed-js
User web3-bot:
  - will lose push permission to js-ipfs-101
  - will lose push permission to js-ipfs-browser-add-readable-stream
  - will lose push permission to js-ipfs-browser-angular
  - will lose push permission to js-ipfs-browser-browserify
  - will lose push permission to js-ipfs-browser-create-react-app
  - will lose push permission to js-ipfs-browser-esbuild
  - will lose push permission to js-ipfs-browser-exchange-files
  - will lose push permission to js-ipfs-browser-ipns-publish
  - will lose push permission to js-ipfs-browser-lit
  - will lose push permission to js-ipfs-browser-mfs
  - will lose push permission to js-ipfs-browser-nextjs
  - will lose push permission to js-ipfs-browser-parceljs
  - will lose push permission to js-ipfs-browser-readablestream
  - will lose push permission to js-ipfs-browser-script-tag
  - will lose push permission to js-ipfs-browser-service-worker
  - will lose push permission to js-ipfs-browser-sharing-node-across-tabs
  - will lose push permission to js-ipfs-browser-video-streaming
  - will lose push permission to js-ipfs-browser-vite
  - will lose push permission to js-ipfs-browser-vue
  - will lose push permission to js-ipfs-browser-webpack
  - will lose push permission to js-ipfs-custom-ipld-formats
  - will lose push permission to js-ipfs-custom-libp2p
  - will lose push permission to js-ipfs-http-client-browser-pubsub
  - will lose push permission to js-ipfs-http-client-bundle-webpack
  - will lose push permission to js-ipfs-http-client-name-api
  - will lose push permission to js-ipfs-http-client-upload-file
  - will lose push permission to js-ipfs-ipfs-client-add-files
  - will lose push permission to js-ipfs-run-in-electron
  - will lose push permission to js-ipfs-running-multiple-nodes
  - will lose push permission to js-ipfs-types-use-ipfs-from-ts
  - will lose push permission to js-ipfs-types-use-ipfs-from-typed-js

@github-actions
Copy link
Contributor

github-actions bot commented Jun 3, 2025

Before merge, verify that all the following plans are correct. They will be applied as-is after the merge.

Terraform plans

ipfs-examples

Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
  ~ update in-place

Terraform will perform the following actions:

  # github_repository.this["js-ipfs-101"] will be updated in-place
  ~ resource "github_repository" "this" {
      ~ archived                    = false -> true
        id                          = "js-ipfs-101"
        name                        = "js-ipfs-101"
        # (32 unchanged attributes hidden)

        # (2 unchanged blocks hidden)
    }

  # github_repository.this["js-ipfs-browser-add-readable-stream"] will be updated in-place
  ~ resource "github_repository" "this" {
      ~ archived                    = false -> true
        id                          = "js-ipfs-browser-add-readable-stream"
        name                        = "js-ipfs-browser-add-readable-stream"
        # (32 unchanged attributes hidden)

        # (2 unchanged blocks hidden)
    }

  # github_repository.this["js-ipfs-browser-angular"] will be updated in-place
  ~ resource "github_repository" "this" {
      ~ archived                    = false -> true
        id                          = "js-ipfs-browser-angular"
        name                        = "js-ipfs-browser-angular"
        # (32 unchanged attributes hidden)

        # (2 unchanged blocks hidden)
    }

  # github_repository.this["js-ipfs-browser-browserify"] will be updated in-place
  ~ resource "github_repository" "this" {
      ~ archived                    = false -> true
        id                          = "js-ipfs-browser-browserify"
        name                        = "js-ipfs-browser-browserify"
        # (32 unchanged attributes hidden)

        # (2 unchanged blocks hidden)
    }

  # github_repository.this["js-ipfs-browser-create-react-app"] will be updated in-place
  ~ resource "github_repository" "this" {
      ~ archived                    = false -> true
        id                          = "js-ipfs-browser-create-react-app"
        name                        = "js-ipfs-browser-create-react-app"
        # (32 unchanged attributes hidden)

        # (2 unchanged blocks hidden)
    }

  # github_repository.this["js-ipfs-browser-esbuild"] will be updated in-place
  ~ resource "github_repository" "this" {
      ~ archived                    = false -> true
        id                          = "js-ipfs-browser-esbuild"
        name                        = "js-ipfs-browser-esbuild"
        # (32 unchanged attributes hidden)

        # (2 unchanged blocks hidden)
    }

  # github_repository.this["js-ipfs-browser-exchange-files"] will be updated in-place
  ~ resource "github_repository" "this" {
      ~ archived                    = false -> true
        id                          = "js-ipfs-browser-exchange-files"
        name                        = "js-ipfs-browser-exchange-files"
        # (32 unchanged attributes hidden)

        # (2 unchanged blocks hidden)
    }

  # github_repository.this["js-ipfs-browser-ipns-publish"] will be updated in-place
  ~ resource "github_repository" "this" {
      ~ archived                    = false -> true
        id                          = "js-ipfs-browser-ipns-publish"
        name                        = "js-ipfs-browser-ipns-publish"
        # (32 unchanged attributes hidden)

        # (2 unchanged blocks hidden)
    }

  # github_repository.this["js-ipfs-browser-lit"] will be updated in-place
  ~ resource "github_repository" "this" {
      ~ archived                    = false -> true
        id                          = "js-ipfs-browser-lit"
        name                        = "js-ipfs-browser-lit"
        # (32 unchanged attributes hidden)

        # (2 unchanged blocks hidden)
    }

  # github_repository.this["js-ipfs-browser-mfs"] will be updated in-place
  ~ resource "github_repository" "this" {
      ~ archived                    = false -> true
        id                          = "js-ipfs-browser-mfs"
        name                        = "js-ipfs-browser-mfs"
        # (32 unchanged attributes hidden)

        # (2 unchanged blocks hidden)
    }

  # github_repository.this["js-ipfs-browser-nextjs"] will be updated in-place
  ~ resource "github_repository" "this" {
      ~ archived                    = false -> true
        id                          = "js-ipfs-browser-nextjs"
        name                        = "js-ipfs-browser-nextjs"
        # (32 unchanged attributes hidden)

        # (2 unchanged blocks hidden)
    }

  # github_repository.this["js-ipfs-browser-parceljs"] will be updated in-place
  ~ resource "github_repository" "this" {
      ~ archived                    = false -> true
        id                          = "js-ipfs-browser-parceljs"
        name                        = "js-ipfs-browser-parceljs"
        # (32 unchanged attributes hidden)

        # (2 unchanged blocks hidden)
    }

  # github_repository.this["js-ipfs-browser-readablestream"] will be updated in-place
  ~ resource "github_repository" "this" {
      ~ archived                    = false -> true
        id                          = "js-ipfs-browser-readablestream"
        name                        = "js-ipfs-browser-readablestream"
        # (32 unchanged attributes hidden)

        # (2 unchanged blocks hidden)
    }

  # github_repository.this["js-ipfs-browser-script-tag"] will be updated in-place
  ~ resource "github_repository" "this" {
      ~ archived                    = false -> true
        id                          = "js-ipfs-browser-script-tag"
        name                        = "js-ipfs-browser-script-tag"
        # (32 unchanged attributes hidden)

        # (2 unchanged blocks hidden)
    }

  # github_repository.this["js-ipfs-browser-service-worker"] will be updated in-place
  ~ resource "github_repository" "this" {
      ~ archived                    = false -> true
        id                          = "js-ipfs-browser-service-worker"
        name                        = "js-ipfs-browser-service-worker"
        # (32 unchanged attributes hidden)

        # (2 unchanged blocks hidden)
    }

  # github_repository.this["js-ipfs-browser-sharing-node-across-tabs"] will be updated in-place
  ~ resource "github_repository" "this" {
      ~ archived                    = false -> true
        id                          = "js-ipfs-browser-sharing-node-across-tabs"
        name                        = "js-ipfs-browser-sharing-node-across-tabs"
        # (32 unchanged attributes hidden)

        # (2 unchanged blocks hidden)
    }

  # github_repository.this["js-ipfs-browser-video-streaming"] will be updated in-place
  ~ resource "github_repository" "this" {
      ~ archived                    = false -> true
        id                          = "js-ipfs-browser-video-streaming"
        name                        = "js-ipfs-browser-video-streaming"
        # (32 unchanged attributes hidden)

        # (2 unchanged blocks hidden)
    }

  # github_repository.this["js-ipfs-browser-vite"] will be updated in-place
  ~ resource "github_repository" "this" {
      ~ archived                    = false -> true
        id                          = "js-ipfs-browser-vite"
        name                        = "js-ipfs-browser-vite"
        # (32 unchanged attributes hidden)

        # (2 unchanged blocks hidden)
    }

  # github_repository.this["js-ipfs-browser-vue"] will be updated in-place
  ~ resource "github_repository" "this" {
      ~ archived                    = false -> true
        id                          = "js-ipfs-browser-vue"
        name                        = "js-ipfs-browser-vue"
        # (32 unchanged attributes hidden)

        # (2 unchanged blocks hidden)
    }

  # github_repository.this["js-ipfs-browser-webpack"] will be updated in-place
  ~ resource "github_repository" "this" {
      ~ archived                    = false -> true
        id                          = "js-ipfs-browser-webpack"
        name                        = "js-ipfs-browser-webpack"
        # (32 unchanged attributes hidden)

        # (2 unchanged blocks hidden)
    }

  # github_repository.this["js-ipfs-custom-ipld-formats"] will be updated in-place
  ~ resource "github_repository" "this" {
      ~ archived                    = false -> true
        id                          = "js-ipfs-custom-ipld-formats"
        name                        = "js-ipfs-custom-ipld-formats"
        # (32 unchanged attributes hidden)

        # (2 unchanged blocks hidden)
    }

  # github_repository.this["js-ipfs-custom-libp2p"] will be updated in-place
  ~ resource "github_repository" "this" {
      ~ archived                    = false -> true
        id                          = "js-ipfs-custom-libp2p"
        name                        = "js-ipfs-custom-libp2p"
        # (32 unchanged attributes hidden)

        # (2 unchanged blocks hidden)
    }

  # github_repository.this["js-ipfs-http-client-browser-pubsub"] will be updated in-place
  ~ resource "github_repository" "this" {
      ~ archived                    = false -> true
        id                          = "js-ipfs-http-client-browser-pubsub"
        name                        = "js-ipfs-http-client-browser-pubsub"
        # (32 unchanged attributes hidden)

        # (2 unchanged blocks hidden)
    }

  # github_repository.this["js-ipfs-http-client-bundle-webpack"] will be updated in-place
  ~ resource "github_repository" "this" {
      ~ archived                    = false -> true
        id                          = "js-ipfs-http-client-bundle-webpack"
        name                        = "js-ipfs-http-client-bundle-webpack"
        # (32 unchanged attributes hidden)

        # (2 unchanged blocks hidden)
    }

  # github_repository.this["js-ipfs-http-client-name-api"] will be updated in-place
  ~ resource "github_repository" "this" {
      ~ archived                    = false -> true
        id                          = "js-ipfs-http-client-name-api"
        name                        = "js-ipfs-http-client-name-api"
        # (32 unchanged attributes hidden)

        # (2 unchanged blocks hidden)
    }

  # github_repository.this["js-ipfs-http-client-upload-file"] will be updated in-place
  ~ resource "github_repository" "this" {
      ~ archived                    = false -> true
        id                          = "js-ipfs-http-client-upload-file"
        name                        = "js-ipfs-http-client-upload-file"
        # (32 unchanged attributes hidden)

        # (2 unchanged blocks hidden)
    }

  # github_repository.this["js-ipfs-ipfs-client-add-files"] will be updated in-place
  ~ resource "github_repository" "this" {
      ~ archived                    = false -> true
        id                          = "js-ipfs-ipfs-client-add-files"
        name                        = "js-ipfs-ipfs-client-add-files"
        # (32 unchanged attributes hidden)

        # (2 unchanged blocks hidden)
    }

  # github_repository.this["js-ipfs-run-in-electron"] will be updated in-place
  ~ resource "github_repository" "this" {
      ~ archived                    = false -> true
        id                          = "js-ipfs-run-in-electron"
        name                        = "js-ipfs-run-in-electron"
        # (32 unchanged attributes hidden)

        # (2 unchanged blocks hidden)
    }

  # github_repository.this["js-ipfs-running-multiple-nodes"] will be updated in-place
  ~ resource "github_repository" "this" {
      ~ archived                    = false -> true
        id                          = "js-ipfs-running-multiple-nodes"
        name                        = "js-ipfs-running-multiple-nodes"
        # (32 unchanged attributes hidden)

        # (2 unchanged blocks hidden)
    }

  # github_repository.this["js-ipfs-types-use-ipfs-from-ts"] will be updated in-place
  ~ resource "github_repository" "this" {
      ~ archived                    = false -> true
        id                          = "js-ipfs-types-use-ipfs-from-ts"
        name                        = "js-ipfs-types-use-ipfs-from-ts"
        # (32 unchanged attributes hidden)

        # (2 unchanged blocks hidden)
    }

  # github_repository.this["js-ipfs-types-use-ipfs-from-typed-js"] will be updated in-place
  ~ resource "github_repository" "this" {
      ~ archived                    = false -> true
        id                          = "js-ipfs-types-use-ipfs-from-typed-js"
        name                        = "js-ipfs-types-use-ipfs-from-typed-js"
        # (32 unchanged attributes hidden)

        # (2 unchanged blocks hidden)
    }

Plan: 0 to add, 31 to change, 0 to destroy.

@2color 2color requested a review from achingbrain June 3, 2025 06:46
Copy link
Contributor

@achingbrain achingbrain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Does removing so much config mean those settings won't be changed by the automation or do they revert to some default value?

@2color
Copy link
Contributor Author

2color commented Jun 3, 2025

Does removing so much config mean those settings won't be changed by the automation or do they revert to some default value?

I am not sure. The config was removed by the automation after I just updated the archived property.

@galargh any insights?

@galargh
Copy link
Contributor

galargh commented Jun 4, 2025

When a repository is archived, we remove all the settings from the YAML config here because those cannot be modified on an archived repository. The only toggle that still works on an archived repo is the one that controls its' archived status. If we were to unarchive a repository, all the settings would be brought back to the YAML config automatically as well.

To check what will be changed by the automation after the merge, you can always refer to the terraform plan posted as a comment. In this case, it's here - #54 (comment) As you can see there, the only thing the automation touches is the archived status of the repositories.

@2color 2color merged commit 5ff937a into master Jun 4, 2025
6 checks passed
@2color 2color deleted the archive-js-examples branch June 4, 2025 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants