downloadCargoPackageFromGit: use cargo package for creating the file list#975
Open
vikanezrimaya wants to merge 1 commit intoipetkov:masterfrom
Open
downloadCargoPackageFromGit: use cargo package for creating the file list#975vikanezrimaya wants to merge 1 commit intoipetkov:masterfrom
cargo package for creating the file list#975vikanezrimaya wants to merge 1 commit intoipetkov:masterfrom
Conversation
…e list This avoids pitfalls with `rg` misinterpreting include/exclude rules, because it uses THE SAME logic `cargo` uses for .crate files. Because it uses Cargo itself. Issues with lock file generation are side-stepped by using `--exclude-lockfile`, which I verified completely disables the check that the lockfile is up-to-date. Fixes ipetkov#962
vikanezrimaya
force-pushed
the
fix/swap-rg-for-cargo-package
branch
from
bb539cc to
cbfdc19
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This avoids pitfalls with
rgmisinterpreting include/exclude rules, because it uses THE SAME logiccargouses for .crate files.Because it uses Cargo itself.
Issues with lock file generation are side-stepped by using
--exclude-lockfile, which I verified completely disables the check that the lockfile is up-to-date.Fixes #962
Checklist
docs/API.md(or general documentation) with changesCHANGELOG.md