improved documentation to constrained_accessibility(), as well as flip in 'active' logic, and fix marginal sums for total constrained accessibility #61
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… improved documentation
soukhova
changed the title
rafapereirabr
approved these changes
Dec 22, 2025
Member
rafapereirabr
left a comment
rafapereirabr
left a comment
There was a problem hiding this comment.
this looks good to me! Thanks @soukhova !
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Building on my last PR related to the
constrained_accessibility(), this PR flipsactivelogic (now,active = TRUEoractive = FALSEinstead ofreturn_demand_sidelogical). It also ensures correct marginal summation in total-constrained accessibility when different land-use zoning systems are used.As well, it addresses issue #60 and includes much more developed documentation.