Conversation
Made cosmetic changes according to PEP8 by using "autopep8" tool.
There was a problem hiding this comment.
Ok in short we need to refactor splitted lines. I put comments on some lines, and there are other similar lines needs to address this splitting. We don't need to strictly follow PEP8 if they're long lines. If they're really long lines try to split them by following other methods such as moving long parameters to new variables, splitting lines after/before new function calls. Instead of using different lines for each parameter maybe they can be grouped in multiple (2 parameters in each line etc...).
Just realized that you used autopep8 tool, if these changes are just made by the tool (not by you) then maybe you can consider to use the tool without telling it to "split the lines"?
Cosmetic arrangements to make functions with a lot of parameters seem more compact.
message parameters passed as parameters
exception messages passed as a variable
exception messages are passed as variable
ceyonur
left a comment
ceyonur
left a comment
There was a problem hiding this comment.
I added comments, there were some bugs and typos. Overall it obeys to PEP8, however some places are aggresively broken to multi-lines. Pep tool tries to wrap the lines after 79 characters but in some places it did some ugly breaks like breaking immediatly after paranthesis. I commented some places, but overall I've seen such cases in almost every file. If editing whole code seems overwhelming, we can split each file one by one and iterate over them. So you can work on one file then push it and get reviews & merge, then you can proceed other files.
Line breaks after open paranthesis are fixed.
Adjustifications about line length.
Adjustifications abot line length.
Adjustifications abot line length. Newlines after open pharanthesis are fixed.
Line length adjustments. Newline after open paranthesis are fixed.
Line adjustifications. Newline after open paranthesis are fixed. Help message passed as a variable.
|
I have fixed the mentioned problems and similar cases in the pull request. |
|
@UkcaGreen I've made some comments on the last review, yet I could not see any related changes for my comments. Have you forgotten to push some commits? |
newline after open pharanthesis is fixed.
newline after open pharanthesis is fixed
getting rid of variable with ambigious name.
Final touches in some files
2 participants
Made cosmetic changes according to PEP8 by using "autopep8" tool.