Conversation
wulfraem
approved these changes
Feb 9, 2026
Contributor
wulfraem
left a comment
wulfraem
left a comment
There was a problem hiding this comment.
LGTM, would just add those two comments to the trait functions, but this is not a blocker for the release.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes the set of discovered bugs during pre-release sanity tests
Issue 1
Maintenance Lock Deleted During Cleanup
The Lua cleanup script was deleting maintenance locks, creating race conditions
Fixed by filtering out lock keys before deletion
Prevents concurrent maintenance operations that could corrupt data
Issue 2
Performance - Redundant Consistency Checks
Consistency check was running on every rescan instead of just once at startup
Moved to the initialization phase only
Reduces unnecessary blockchain RPC calls
Issue 3
Cold Params Invalid Key
The storage key was constructed incorrectly with a doubled and an invalid prefix
Added centralized get_cold_params_key() helper function
Ensures consistent key format across all operations and cold params db key exists isolated from coin registry namespace#
Issue 4
Cold Params Not Properly Saved
Check operation was mixing concerns by saving params during the check
Split into separate check_if_changed() and save_to_storage() methods
Now saves only after successful initialization with proper user consent. It prevents the situation the user would like to come back to the old parameter without a rescan being triggered