This repository was archived by the owner on May 27, 2021. It is now read-only.
Several bug fixes from various authors + exposing isOpen function to the $scope#27
Open
redfox05 wants to merge 40 commits intoionic-team:masterfrom
Open
Several bug fixes from various authors + exposing isOpen function to the $scope#27redfox05 wants to merge 40 commits intoionic-team:masterfrom
redfox05 wants to merge 40 commits intoionic-team:masterfrom
Conversation
Run demo code with 'grunt connect' command on command line
- Exposed isOpen function to the $scope - Example code to show control of drawer from nav bar - Example code to move drawer + drawer grey overlay down by 44px
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Several bugfixes from various owners are included in this as well as the ability to control/check drawer state from outside of the menu using the isOpen function exposed to the $scope as $scope.drawerIsOpen() returning true or false.
There are many different forks of this drawer since driftyco made the last commit about a year ago, so I have traced the fork route with the most fixes, and then added my additions on top.
This pull-request is to add this all back into the original repo by driftyco, so that future development/forks can benefit from all the bug fixes several authors have made, rather than being unsure which fork to use.