This repository was archived by the owner on May 27, 2021. It is now read-only.
Fix for closing problem from the right#12
Open
kel-sakal-biyik wants to merge 1 commit intoionic-team:masterfrom
Open
Fix for closing problem from the right#12kel-sakal-biyik wants to merge 1 commit intoionic-team:masterfrom
kel-sakal-biyik wants to merge 1 commit intoionic-team:masterfrom
Conversation
If you choose to place the drawer to the right by using side attribute, while dragging the drawer to close it, it closes to the left again.
|
It works. But not ideally. For example once it is opened if I try to slide it back, it just dissapears instead of transitioning. Also I cannot drag it back. Have a look at my code. I know it is ugly, I just did a quick fix specific for my case. I need to clean it up and do PR someday. https://github.com/Yuripetusko/ionic-ion-drawer/commits/master |
Author
|
Strange. It should go away with transition. I will check again. I will also check yours. Thanks! |
Author
|
Here I have created a pen: http://codepen.io/kel-sakal-biyik/pen/QwzGYe If you decrease the width of the viewport, transition should also work. |
|
Hello. I created a PR of my won for the same issue. #13 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If you choose to place the drawer to the right by using side attribute, while dragging the drawer to close it, it closes to the left again.