Draft
Conversation
Collaborator
Author
|
@rsjethani can I have your opinion in this please? 😇 |
Collaborator
|
Sorry, I fail to see the point here. As per my understanding, the CLI part can be compiled and distributed using new go versions anyways while not increasing the go version of the module. IMO the toolchain configuration is for complex situations and changing it for a simple wrapper code like ours is adding unnecessary complexity. No? I miss something? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #82
Given this comment I removed the test matrix at all..