Fix mypy typing #642
Draft
Fix mypy typing #642
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I've enabled the mypy session in the CI and improved the typing of the codebase. I made the mypy configuration in `pyproject.toml` more strict to enforce better type checking and fixed several typing errors, including a syntax error in `src/invoice2data/extract/plugins/tables.py`. Please be aware of an issue I found with `mypy` and `nox`. Running `mypy` through `nox` doesn't report any errors, but running it directly does. This suggests the `nox` environment isn't set up correctly for `mypy`, so the `mypy` job in the CI will likely fail. This will need further investigation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.