[RFC] Add database and searchengine templates for services.*.extends support#143
Draft
andytson-inviqa wants to merge 3 commits into0.4.xfrom
Draft
[RFC] Add database and searchengine templates for services.*.extends support#143andytson-inviqa wants to merge 3 commits into0.4.xfrom
andytson-inviqa wants to merge 3 commits into0.4.xfrom
Conversation
```yaml
services:
console:
extends:
- _database-access
- _searchengine-access
```
Contributor
Author
|
ah, well extends works in the helm chart but isn't used in the twig templating of docker-compose.yml yet |
Contributor
Author
|
although a case against merge of config, in heinsight I'd have made php-base it's own k8s secret and maybe configmap as is confusing it not matching it's sealedsecret encrypted secret name and copied into multiple secrets |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What do people think of this idea?
I don't want to pollute the variables in console in docker harness, and reuse would be needed in PHP harnesses for php-base, so the ignored _service-name syntax (which is also used for _php-base) could be used here.