[codex] security and privacy hardening#19
Draft
johnzfitch wants to merge 2 commits intoinvestblog:mainfrom
Draft
[codex] security and privacy hardening#19johnzfitch wants to merge 2 commits intoinvestblog:mainfrom
johnzfitch wants to merge 2 commits intoinvestblog:mainfrom
Conversation
Author
|
@codex security review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR applies a focused security and privacy hardening pass to CookiePeek and updates dependency hygiene.
The core goals were:
innerHTMLsink to lower future XSS regression risk,User-Visible Effect
Users keep the same cookie management features and the popup external links remain available (store/review/support/social/sponsor).
Security/Privacy Impact
<all_urls>tohttp://*/*andhttps://*/*, removing unnecessary access to internal browser schemes.innerHTML; it is rendered via safe DOM helpers.npm audithigh-severity findings.Root Cause
innerHTMLassignment existed in UI code.Implementation Details
wxt.config.tshost_permissionschanged to['http://*/*', 'https://*/*'].src/entrypoints/popup/main.tssrc/entrypoints/popup/components/change-log.tsinnerHTMLassignment withsvgIcon(ICONS.x, 16).package.jsonwxtto^0.20.18.overridesfortarandminimatchto force patched transitive versions.package-lock.jsonsrc/background/cookies.tswxtbrowser typings.docs/PRIVACY.md,docs/TESTING.md,docs/SPEC.md,README.mdValidation
Executed locally:
npm audit --package-lock-only->found 0 vulnerabilitiesnpm run checkNotes
This PR intentionally keeps functional scope narrow and focuses on privacy/security hardening plus dependency remediation.