update axios dependency and update tests#283
Merged
Samk13 merged 9 commits intoinveniosoftware:maint-2.xfrom May 5, 2025
Merged
update axios dependency and update tests#283Samk13 merged 9 commits intoinveniosoftware:maint-2.xfrom
Samk13 merged 9 commits intoinveniosoftware:maint-2.xfrom
Conversation
added 2 commits
May 2, 2025 12:09
* Add TextEncoder, TextDecoder, ReadableStream as globals due to jsdom/jsdom#2524 * Pin `cheerio` due to enzymejs/enzyme#2558 * Add option `--transformIgnorePatterns /\"node_modules/(?!axios)/\"` to instruct jest to transform "node_modules/axios"
Samk13
force-pushed
the
fix-axios-version
branch
3 times, most recently
from
7349351 to
04d836b
Compare
Samk13
commented
May 2, 2025
* ci: include maint branche & upgrade Ubuntu version * chore: update CI to use Ubuntu 24.04 for testing
utnapischtim
reviewed
May 5, 2025
utnapischtim
reviewed
May 5, 2025
utnapischtim
reviewed
May 5, 2025
utnapischtim
approved these changes
May 5, 2025
* remove end of life node versions from the matrix * update branch pattern
* fix the issue when running npm run lint: Oops! Something went wrong! :( ESLint: 6.8.0. ESLint couldn't find the config "react-app" to extend from. Please check that the name of the config is correct.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
related to inveniosoftware/invenio-search-ui#215
Update axios deps 1.8.2
Add
TextEncoder,TextDecoder, andReadableStreamas globals to address ImplementTextEncoderandTextDecoderjsdom/jsdom#2524. Updateaxiosandaxios-mock-adapterversions inpackage.json, pincheeriodue to an issue with enzyme, and modify Jest test command to transformnode_modules/axios. Fix tests to accommodate these changes.Question:
should we merge this, or bump the upper pin here: https://github.com/inveniosoftware/invenio-rdm-records/blob/maint-10.x/invenio_rdm_records/webpack.py#L40C38-L40C44