UX: Add THEME_SITENAME as a suffix in <head>#382
UX: Add THEME_SITENAME as a suffix in <head>#382carlinmack wants to merge 3 commits intoinveniosoftware:masterfrom
Conversation
| {%- block head_title %} | ||
| {%- set title = title or _(config.THEME_SITENAME) or _('Invenio') %} | ||
| <title>{{title}}</title> | ||
| <title>{%- if title %}{{title}} | {% endif -%}{{ _(config.THEME_SITENAME) or _('Invenio') }}</title> |
There was a problem hiding this comment.
LGTM code-wise.
all the instances running invenio will be affected by this change, was that the goal ?
There was a problem hiding this comment.
Yep, this is beneficial for all instances in my opinion
The only problem I can foresee is if they haven't set THEME_SITENAME then they will have Invenio appended
There was a problem hiding this comment.
could you add a section "Update configuration variables" under
https://github.com/inveniosoftware/docs-invenio-rdm/pull/607/files#diff-39da3e2af9ef047f00739348879d5a91714f7b1cf3f693c959a9e6154c2b9795R125
explaining exactly this? It should go into the upgrade guidelines for v12
There was a problem hiding this comment.
Added a comment! btw this variable has already been contributed to cookiecutter :) inveniosoftware/cookiecutter-invenio-rdm#273
There was a problem hiding this comment.
Ok to merge from me if there is not a chance we'll have Zenodo | Zenodo? For that we'll just need to check if title is every set to config.THEME_SITENAME
4 participants
❤️ Thank you for your contribution!
Description
Please describe briefly your pull request.
Currently the
<head>is either the "<sitename>" or some custom string like "Communities", "Requests" etc. This PR results instead in "Communities | <sitename>", "Requests | <sitename>", etcChecklist
Ticks in all boxes and 🟢 on all GitHub actions status checks are required to merge:
Third-party code
If you've added third-party code (copy/pasted or new dependencies), please reach out to an architect.
Reminder
By using GitHub, you have already agreed to the GitHub’s Terms of Service including that:
Close https://github.com/zenodo/ops/issues/390