Skip to content

Conversation

@geekdinazor
Copy link

❤️ Thank you for your contribution!

Description

This PR introduces JS translation distribution functionality to invenio-cli installcommand.

Warning

This PR use commands for translation distribution from invenio-i18n PR 140

Checklist

Ticks in all boxes and 🟢 on all GitHub actions status checks are required to merge:

Frontend
This development is backend only.

Reminder

By using GitHub, you have already agreed to the GitHub’s Terms of Service including that:

  1. You license your contribution under the same terms as the current repository’s license.
  2. You agree that you have the right to license your contribution under the current repository’s license.

…ommand.

* New `js_translations_bundle_path` config added to `.invenio.private`  to specify the source path where the `invenio i18n distribute-js-translations` command retrieves merged translation files.
* Default value of `js_translations_bundle_path` is `<project_dir>/js_translations` for now. It may change later.
* `invenio i18n distribute-js-translations` command run before webpack build to distribute JS/React translations to relevant Python packages.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant