enabling versioning of documentation:#45
Open
ppanero wants to merge 4 commits intoinveniosoftware:masterfrom
Open
enabling versioning of documentation:#45ppanero wants to merge 4 commits intoinveniosoftware:masterfrom
ppanero wants to merge 4 commits intoinveniosoftware:masterfrom
Conversation
Collaborator
|
We are not using https://github.com/zayd62/mkdocs-versioning/ in the end? Your fix has been merged in. Seems like |
fenekku
reviewed
Mar 30, 2020
Collaborator
fenekku
left a comment
fenekku
left a comment
There was a problem hiding this comment.
Question above about using this over the other plugin...
| @@ -1,76 +1,79 @@ | |||
| # Project information | |||
Collaborator
There was a problem hiding this comment.
Question: Does mike auto-rewrite the mkdocs.yml? I am not sure I like this 😅
| extra_css: | ||
| - stylesheets/extra.css | ||
|
|
||
| # Extensions |
Collaborator
There was a problem hiding this comment.
minor: misalignment of the comment I think
| permalink: true | ||
| permalink: true | ||
| extra_javascript: | ||
| - js/version-select.js |
Collaborator
There was a problem hiding this comment.
moderate: Are indentation: 4 spaces or 2 spaces?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #44
Instructions have been moved to the README file.
Open Questions:
from ruamel.yaml.util import load_yaml_guess_indentin theinstall_extrascommand. Somehow it is interpreting 4 spaces instead of 2.installtab instead of thehomeone. This can be modified in thedocs/js/version-select.jsand it is easy to do. However, we can just put it somewhere different, top corners? bottom corners? WDYT?Example:
https://ppanero.github.io/docs-invenio-rdm/0.7.0/
https://ppanero.github.io/docs-invenio-rdm/0.7.1/
https://ppanero.github.io/docs-invenio-rdm/latest/ --> points to https://ppanero.github.io/docs-invenio-rdm/0.7.1/
https://ppanero.github.io/docs-invenio-rdm/ --> redirect to https://ppanero.github.io/docs-invenio-rdm/latest